From af28e6419f4eea3441654c30eb69c99033ec3786 Mon Sep 17 00:00:00 2001 From: derdeagle Date: Mon, 19 Jun 2023 13:12:20 +0200 Subject: [PATCH] Fixes #179: Add missing /tool/e-mail parameter "tls" (#180) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Fixes #179: Add missing /tool/e-mail parameter "tls" In the [documentation](https://help.mikrotik.com/docs/display/ROS/E-mail#Email-Properties) the parameter "tls" is mentioned but it cannot be used. The old "start-tls" parameter is not mentioned there (only on the [old documentation](https://wiki.mikrotik.com/wiki/Manual:Tools/email#Properties)). Trying to use the paramter "tls" lead to the erro message `FAILED! => {"changed": false, "msg": "Unknown key \"tls\"."}`. * Add changelog fragment * Update changelogs/fragments/180-fix-tls-in-tool-email.yml As suggested by felixfontein Co-authored-by: Felix Fontein --------- Co-authored-by: Johannes Münch Co-authored-by: Felix Fontein --- changelogs/fragments/180-fix-tls-in-tool-email.yml | 2 ++ plugins/module_utils/_api_data.py | 1 + 2 files changed, 3 insertions(+) create mode 100644 changelogs/fragments/180-fix-tls-in-tool-email.yml diff --git a/changelogs/fragments/180-fix-tls-in-tool-email.yml b/changelogs/fragments/180-fix-tls-in-tool-email.yml new file mode 100644 index 00000000..0a694985 --- /dev/null +++ b/changelogs/fragments/180-fix-tls-in-tool-email.yml @@ -0,0 +1,2 @@ +bugfixes: + - api_modify, api_info - add missing parameter ``tls`` for the ``tool e-mail`` path (https://github.com/ansible-collections/community.routeros/issues/179, https://github.com/ansible-collections/community.routeros/pull/180). diff --git a/plugins/module_utils/_api_data.py b/plugins/module_utils/_api_data.py index 0d3e82f7..59e5b5c5 100644 --- a/plugins/module_utils/_api_data.py +++ b/plugins/module_utils/_api_data.py @@ -2451,6 +2451,7 @@ def join_path(path): 'password': KeyInfo(default=''), 'port': KeyInfo(default=25), 'start-tls': KeyInfo(default=False), + 'tls': KeyInfo(default=False), 'user': KeyInfo(default=''), }, ),