auth: add env and ini var for mount_point option #171

horazont · 2021-11-01T10:16:27Z

SUMMARY

This makes most sense; it is part of the credentials needed to
authenticate with vault, e.g. on servers with multiple independent
AppRole mountpoints.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

auth methods

ADDITIONAL INFORMATION

Hopefully self-explanatory, if it is not, please let me know.

briantist · 2021-11-02T02:28:02Z

Hello @horazont and welcome! Thanks for submitting this.
Please also add a changelog fragment in the format described. You may use auth methods for the scope portion, and the link at the end can point at this PR.

codecov · 2021-11-02T02:45:58Z

Codecov Report

Merging #171 (2c6a957) into main (af71153) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          40       40           
  Lines        1587     1587           
  Branches      123      123           
=======================================
  Hits         1455     1455           
  Misses        119      119           
  Partials       13       13

Flag	Coverage Δ
env_docker-default	`91.68% <ø> (ø)`
integration	`75.80% <ø> (ø)`
py2.6	`36.18% <ø> (ø)`
py2.7	`83.49% <ø> (ø)`
py3.10	`90.80% <ø> (ø)`
py3.5	`83.74% <ø> (ø)`
py3.6	`83.74% <ø> (ø)`
py3.7	`83.74% <ø> (ø)`
py3.8	`90.86% <ø> (ø)`
py3.9	`90.86% <ø> (ø)`
sanity	`37.76% <ø> (ø)`
target_ansible-doc	`100.00% <ø> (ø)`
target_auth_approle	`89.47% <ø> (ø)`
target_auth_cert	`56.40% <ø> (ø)`
target_auth_jwt	`91.30% <ø> (ø)`
target_auth_none	`100.00% <ø> (ø)`
target_auth_token	`71.42% <ø> (ø)`
target_connection_options	`74.76% <ø> (ø)`
target_controller	`67.00% <ø> (ø)`
target_import	`37.76% <ø> (ø)`
target_lookup_hashi_vault	`81.33% <ø> (ø)`
target_lookup_vault_read	`90.00% <ø> (ø)`
target_module_utils	`90.40% <ø> (ø)`
target_module_vault_read	`92.10% <ø> (ø)`
units	`88.78% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
plugins/doc_fragments/auth.py	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af71153...2c6a957. Read the comment docs.

horazont · 2021-11-04T07:32:25Z

Hi @briantist. Sorry for the late reaction, GitHub email notifications aren't reliable for me because they end up in my private inbox instead of my work inbox for this.

Anyway, am I doing this right? :)

changelogs/fragments/pr-171-envvar-for-mount-point.yaml

briantist · 2021-11-04T18:39:21Z

@horazont please also rebase your branch against the upstream main, as I fixed the issue with the macos CI job failing.

This makes most sense; it is part of the credentials needed to authenticate with vault, e.g. on servers with multiple independent AppRole mountpoints.

github-actions · 2021-11-05T13:51:11Z

##Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://community-hashi-vault-main.surge.sh

briantist · 2021-11-05T15:04:45Z

changelogs/fragments/pr-171-envvar-for-mount-point.yaml

@@ -0,0 +1,2 @@
+minor_changes:
+- auth methods - Add support for configuring the ``mount_point`` auth method option in plugins via the ``HASHI_VAULT_MOUNT_POINT`` environment variable, ``ansible_hashi_vault_mount_point`` ansible variable, or ``mount_point`` INI section (https://github.com/ansible-collections/community.hashi_vault/pull/171).


I messed up the wording on this 🤦‍♂️ I'm going to merge this and "fix it in post" since I am on a short timeline for the release of 1.5.0 and then 2.0.0.

Suggested change

- auth methods - Add support for configuring the ``mount_point`` auth method option in plugins via the ``HASHI_VAULT_MOUNT_POINT`` environment variable, ``ansible_hashi_vault_mount_point`` ansible variable, or ``mount_point`` INI section (https://github.com/ansible-collections/community.hashi_vault/pull/171).

- auth methods - Add support for configuring the ``mount_point`` auth method option in plugins via the ``ANSIBLE_HASHI_VAULT_MOUNT_POINT`` environment variable, ``ansible_hashi_vault_mount_point`` ansible variable, or ``mount_point`` INI section (https://github.com/ansible-collections/community.hashi_vault/pull/171).

* correct changelog wording for #171 * prepare 1.5.0 release * remove redundant scope in changelog * release 1.5.0

horazont temporarily deployed to docs-build November 1, 2021 10:16 Inactive

briantist self-assigned this Nov 1, 2021

briantist added the enhancement New feature or request label Nov 1, 2021

briantist added this to the v1.5.0 milestone Nov 1, 2021

horazont force-pushed the feature/auth-mount-point-vars branch from b86b5e6 to a1846bf Compare November 4, 2021 07:30

horazont temporarily deployed to docs-build November 4, 2021 07:30 Inactive

briantist reviewed Nov 4, 2021

View reviewed changes

changelogs/fragments/pr-171-envvar-for-mount-point.yaml Outdated Show resolved Hide resolved

horazont force-pushed the feature/auth-mount-point-vars branch from a1846bf to ed7a087 Compare November 5, 2021 10:57

horazont had a problem deploying to docs-build November 5, 2021 10:57 Error

horazont had a problem deploying to docs-build November 5, 2021 11:09 Error

auth: add env and ini var for mount_point option

2c6a957

This makes most sense; it is part of the credentials needed to authenticate with vault, e.g. on servers with multiple independent AppRole mountpoints.

horazont force-pushed the feature/auth-mount-point-vars branch from f8f68bf to 2c6a957 Compare November 5, 2021 11:09

horazont had a problem deploying to docs-build November 5, 2021 11:09 Error

horazont temporarily deployed to docs-build November 5, 2021 13:39 Inactive

briantist reviewed Nov 5, 2021

View reviewed changes

briantist merged commit 8be0541 into ansible-collections:main Nov 5, 2021

briantist added a commit to briantist/community.hashi_vault that referenced this pull request Nov 5, 2021

correct changelog wording for ansible-collections#171

a8bc1f8

briantist added a commit that referenced this pull request Nov 5, 2021

Release 1.5.0 (#178)

147531d

* correct changelog wording for #171 * prepare 1.5.0 release * remove redundant scope in changelog * release 1.5.0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

auth: add env and ini var for mount_point option #171

auth: add env and ini var for mount_point option #171

horazont commented Nov 1, 2021 •

edited

Loading

briantist commented Nov 2, 2021

codecov bot commented Nov 2, 2021 •

edited

Loading

horazont commented Nov 4, 2021

briantist commented Nov 4, 2021

github-actions bot commented Nov 5, 2021 •

edited

Loading

briantist Nov 5, 2021

		@@ -0,0 +1,2 @@
		minor_changes:
		- auth methods - Add support for configuring the ``mount_point`` auth method option in plugins via the ``HASHI_VAULT_MOUNT_POINT`` environment variable, ``ansible_hashi_vault_mount_point`` ansible variable, or ``mount_point`` INI section (https://github.com/ansible-collections/community.hashi_vault/pull/171).

auth: add env and ini var for mount_point option #171

auth: add env and ini var for mount_point option #171

Conversation

horazont commented Nov 1, 2021 • edited Loading

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

briantist commented Nov 2, 2021

codecov bot commented Nov 2, 2021 • edited Loading

Codecov Report

horazont commented Nov 4, 2021

briantist commented Nov 4, 2021

github-actions bot commented Nov 5, 2021 • edited Loading

briantist Nov 5, 2021

Choose a reason for hiding this comment

horazont commented Nov 1, 2021 •

edited

Loading

codecov bot commented Nov 2, 2021 •

edited

Loading

github-actions bot commented Nov 5, 2021 •

edited

Loading