keycloak module utils replace missing return in get_role_composites
#9691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
felixfontein
reviewed
Feb 5, 2025
...elogs/fragments/9691-keycloak-module-utils-replace-missing-return-in-get_role_composites.yml
Outdated
Show resolved
Hide resolved
felixfontein
added
check-before-release
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Feb 8, 2025
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #9703 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 8, 2025
…#9691) * fix: replace missing return (#9678) * chore: add changelog fragment (#9678) * chore: update changelog fragment (#9678) Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 41caa9a)
|
@armkeh thanks for fixing this! |
felixfontein
pushed a commit
that referenced
this pull request
Feb 8, 2025
… missing return in `get_role_composites` (#9703) keycloak module utils replace missing return in `get_role_composites` (#9691) * fix: replace missing return (#9678) * chore: add changelog fragment (#9678) * chore: update changelog fragment (#9678) Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 41caa9a) Co-authored-by: Mark Armstrong <[email protected]>
felixfontein
removed
the
check-before-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #9678.
Replaces a
returnaccidentally removed by #9494.ISSUE TYPE
COMPONENT NAME
module_utils/identity/keycloak