-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iptables_state is broken again on ansible/ansible's devel branch #2700
Comments
Files identified in the description: If these files are inaccurate, please update the |
According to @bcoca we must not call the async_status module, but the async_status action plugin. An example how to do that is in the template action plugin: https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/action/template.py#L179-L186 |
This will get fixed in ansible/ansible's devel branch, with the code of the async_status module getting a deprecation, but we should still switch to using the action plugin because a) it's the correct way to do it since ansible >= 0.4 (according to @bcoca), and b) it will break again once the deprecation expires :) |
(ansible/ansible#74908 resurrects the async_status module for now) |
!component +=plugins/action/system/iptables_state.py |
Files identified in the description: If these files are inaccurate, please update the |
!component =plugins/action/system/iptables_state.py |
Files identified in the description: If these files are inaccurate, please update the |
Summary
I think this time it's due to ansible/ansible@9c718cc
See https://dev.azure.com/ansible/b24bf3ca-6168-45d7-99e2-bf8029e67c87/_apis/build/builds/16908/logs/1600 and https://dev.azure.com/ansible/b24bf3ca-6168-45d7-99e2-bf8029e67c87/_apis/build/builds/16908/logs/1583 for CI runs.
Issue Type
Bug Report
Component Name
iptables_state
Ansible Version
devel
Configuration
OS / Environment
Steps to Reproduce
Expected Results
Actual Results
Code of Conduct
The text was updated successfully, but these errors were encountered: