From 9eea5b95365969a24ce0c9f3d58569a7e6436f2a Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Sat, 12 Mar 2022 13:53:55 +0100 Subject: [PATCH 1/5] Update Environments used by lambda integration tests --- tests/integration/targets/aws_secret/tasks/rotation.yml | 4 ++-- tests/integration/targets/lambda/tasks/main.yml | 8 ++++---- tests/integration/targets/lambda_alias/tasks/main.yml | 6 +++--- tests/integration/targets/lambda_policy/tasks/main.yml | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/integration/targets/aws_secret/tasks/rotation.yml b/tests/integration/targets/aws_secret/tasks/rotation.yml index 823696dbcfc..5a1d146e51a 100644 --- a/tests/integration/targets/aws_secret/tasks/rotation.yml +++ b/tests/integration/targets/aws_secret/tasks/rotation.yml @@ -55,7 +55,7 @@ name: "{{ lambda_name }}" state: present zip_file: "{{ tmp.path }}/hello_world.zip" - runtime: 'python2.7' + runtime: 'python3.9' role: "{{ iam_role_output.arn }}" handler: 'hello_world.lambda_handler' register: lambda_output @@ -169,7 +169,7 @@ name: "{{ lambda_name }}" state: absent zip_file: "{{ tmp.path }}/hello_world.zip" - runtime: 'python2.7' + runtime: 'python3.9' role: "{{ secret_manager_role }}" handler: 'hello_world.lambda_handler' ignore_errors: yes diff --git a/tests/integration/targets/lambda/tasks/main.yml b/tests/integration/targets/lambda/tasks/main.yml index 8846a01cb41..a7a1680d9e6 100644 --- a/tests/integration/targets/lambda/tasks/main.yml +++ b/tests/integration/targets/lambda/tasks/main.yml @@ -125,7 +125,7 @@ - name: test lambda config updates lambda: name: '{{lambda_function_name}}' - runtime: nodejs10.x + runtime: nodejs14.x tracing_mode: Active handler: mini_lambda.handler role: '{{ lambda_role_name }}' @@ -139,13 +139,13 @@ that: - update_result is not failed - update_result.changed == True - - update_result.configuration.runtime == 'nodejs10.x' + - update_result.configuration.runtime == 'nodejs14.x' - update_result.configuration.tracing_config.mode == 'Active' - name: test no changes are made with the same parameters repeated lambda: name: '{{lambda_function_name}}' - runtime: nodejs10.x + runtime: nodejs14.x tracing_mode: Active handler: mini_lambda.handler role: '{{ lambda_role_name }}' @@ -159,7 +159,7 @@ that: - update_result is not failed - update_result.changed == False - - update_result.configuration.runtime == 'nodejs10.x' + - update_result.configuration.runtime == 'nodejs14.x' - update_result.configuration.tracing_config.mode == 'Active' - name: reset config updates for the following tests diff --git a/tests/integration/targets/lambda_alias/tasks/main.yml b/tests/integration/targets/lambda_alias/tasks/main.yml index 6796d14cca6..9b264f50c0a 100644 --- a/tests/integration/targets/lambda_alias/tasks/main.yml +++ b/tests/integration/targets/lambda_alias/tasks/main.yml @@ -37,7 +37,7 @@ - name: Upload test lambda (version 1) lambda: name: '{{ lambda_function_name }}' - runtime: 'python2.7' + runtime: 'python3.7' handler: 'mini_lambda.handler' role: '{{ lambda_role_name }}' zip_file: '{{ zip_res.dest }}' @@ -50,7 +50,7 @@ - name: Update lambda (version 2) lambda: name: '{{ lambda_function_name }}' - runtime: 'python3.6' + runtime: 'python3.8' handler: 'mini_lambda.handler' role: '{{ lambda_role_name }}' register: lambda_b @@ -62,7 +62,7 @@ - name: Update lambda (version 3 / LATEST) lambda: name: '{{ lambda_function_name }}' - runtime: 'python3.7' + runtime: 'python3.9' handler: 'mini_lambda.handler' role: '{{ lambda_role_name }}' register: lambda_c diff --git a/tests/integration/targets/lambda_policy/tasks/main.yml b/tests/integration/targets/lambda_policy/tasks/main.yml index 2b0e3d38f9f..e0b514bde43 100644 --- a/tests/integration/targets/lambda_policy/tasks/main.yml +++ b/tests/integration/targets/lambda_policy/tasks/main.yml @@ -61,7 +61,7 @@ - name: test state=present - upload the lambda lambda: name: '{{lambda_function_name}}' - runtime: python2.7 + runtime: python3.9 handler: mini_http_lambda.handler role: '{{ lambda_role_name }}' zip_file: '{{zip_res.dest}}' From 11c93d4786906a7727ded1e57a04aeac4d932605 Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Sat, 12 Mar 2022 16:31:36 +0100 Subject: [PATCH 2/5] Add retries to s3_bucket_notification - permissions are being set, but they're not being recognised --- .../integration/targets/s3_bucket_notification/tasks/main.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/integration/targets/s3_bucket_notification/tasks/main.yml b/tests/integration/targets/s3_bucket_notification/tasks/main.yml index fc9b4bb2272..73caae733bc 100644 --- a/tests/integration/targets/s3_bucket_notification/tasks/main.yml +++ b/tests/integration/targets/s3_bucket_notification/tasks/main.yml @@ -85,6 +85,10 @@ prefix: images/ suffix: .jpg register: result + retries: 3 + delay: 3 + until: + - result is successful - name: assert result.changed == True assert: that: From fbee914af62134f6e31bf91a5303c91af2822517 Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Sat, 12 Mar 2022 17:16:47 +0100 Subject: [PATCH 3/5] rds_instance: make sure we delete our snapshots --- .../rds_instance/roles/rds_instance/tasks/test_tagging.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_tagging.yml b/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_tagging.yml index bb84a63d95d..16511f4ac6f 100644 --- a/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_tagging.yml +++ b/tests/integration/targets/rds_instance/roles/rds_instance/tasks/test_tagging.yml @@ -143,9 +143,9 @@ - "result.snapshots.0.engine == 'mariadb'" always: - - name: remove snapshot + - name: remove final snapshot rds_instance_snapshot: - db_snapshot_identifier: "{{ tiny_prefix }}-test-snapshot" + db_snapshot_identifier: "{{ instance_id }}" state: absent wait: false ignore_errors: yes From 1734085ae032ed745fd32ba8d3da6f20cff93b34 Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Sun, 13 Mar 2022 14:13:53 +0100 Subject: [PATCH 4/5] disable broken wafv2 tests --- tests/integration/targets/wafv2/aliases | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/integration/targets/wafv2/aliases b/tests/integration/targets/wafv2/aliases index 53978c542e1..b473fb47536 100644 --- a/tests/integration/targets/wafv2/aliases +++ b/tests/integration/targets/wafv2/aliases @@ -1,4 +1,6 @@ cloud/aws +# reason: Tests broken - https://github.com/ansible-collections/community.aws/issues/985 +disabled wafv2_resources wafv2_resources_info From 7bcd0d294874a26d9d715a514800a00f569b3d3b Mon Sep 17 00:00:00 2001 From: Mark Chappell Date: Sun, 13 Mar 2022 14:15:22 +0100 Subject: [PATCH 5/5] use tiny_prefix rather than regex hack --- tests/integration/targets/wafv2/defaults/main.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/integration/targets/wafv2/defaults/main.yml b/tests/integration/targets/wafv2/defaults/main.yml index a019a97eaab..ac23638ca83 100644 --- a/tests/integration/targets/wafv2/defaults/main.yml +++ b/tests/integration/targets/wafv2/defaults/main.yml @@ -1,11 +1,11 @@ --- -web_acl_name: '{{ resource_prefix }}-web-acl' -rule_group_name: '{{ resource_prefix }}-rule-group' -alb_name: "my-alb-{{ resource_prefix | regex_search('([0-9]+)$') }}" -tg_name: "my-tg-{{ resource_prefix | regex_search('([0-9]+)$') }}" +web_acl_name: '{{ tiny_prefix }}-web-acl' +rule_group_name: '{{ tiny_prefix }}-rule-group' +alb_name: "my-alb-{{ tiny_prefix }}" +tg_name: "my-tg-{{ tiny_prefix }}" cidr: main: 10.228.228.0/22 a: 10.228.228.0/24 b: 10.228.229.0/24 c: 10.228.230.0/24 - d: 10.228.231.0/24 \ No newline at end of file + d: 10.228.231.0/24