Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change proposal: support valid_from and expiry dates for keyvaultsecrets #658

Closed
howardjones opened this issue Oct 18, 2021 · 2 comments
Closed
Labels
enhancement New feature or request has_pr PR fixes have been made medium_priority Medium priority

Comments

@howardjones
Copy link
Contributor

Update azure_rm_keyvaultsecret to support the not_before and expires properties for a secret.

I have already made these changes in my local copy. The CONTRIBUTING doc said I should create an issue before a pull request.

@Fred-sun
Copy link
Collaborator

@howardjones Making an Issue helps review PR and address validation issues. Welcome to submit the Pull request. I will push forward the review and merger as soon as possible. Thank you very much!

@rstarov
Copy link

rstarov commented Oct 21, 2021

Hi, I think it is really useful feature if you need to control secrets lifecycle (like SAS or Service Principal passwords and etc.) When we can expect this feature to be included in the release ?

@Fred-sun Fred-sun added the has_pr PR fixes have been made label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request has_pr PR fixes have been made medium_priority Medium priority
Projects
None yet
Development

No branches or pull requests

3 participants