Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying --max-pods for node pools in azure_rm_aks #308

Closed
pvorb opened this issue Oct 30, 2020 · 2 comments · Fixed by #440
Closed

Support specifying --max-pods for node pools in azure_rm_aks #308

pvorb opened this issue Oct 30, 2020 · 2 comments · Fixed by #440
Labels
medium_priority Medium priority work in In trying to solve, or in working with contributors

Comments

@pvorb
Copy link

pvorb commented Oct 30, 2020

SUMMARY

As far as I can see, there's currently no way to set the maximum number of pods allowed on one node in a node pool if the Azure CNI network provider is used.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

azure_rm_aks

ADDITIONAL INFORMATION

This feature would basically just allow to specify how many pods can deployed on a single node in a node pool. This is already possible with other tools like the az CLI via the --max-pods parameter.

- name: Create a managed Azure Container Services (AKS) instance
  azure_rm_aks:
    name: myAKS
    location: eastus
    resource_group: myResourceGroup
    dns_prefix: akstest
    kubernetes_version: 1.14.6
    linux_profile:
      admin_username: azureuser
      ssh_key: ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAA...
    network_profile:
      load_balancer_sku: standard
      network_plugin: azure
      network_policy: azure
    service_principal:
      client_id: "cf72ca99-f6b9-4004-b0e0-bee10c521948"
      client_secret: "Password123!"
    agent_pool_profiles:
      - name: default
        count: 5
        vm_size: Standard_D2_v2
        max_pods: 128 # <-- this is the new configuration feature
    tags:
      Environment: Production
@Fred-sun
Copy link
Collaborator

Fred-sun commented Nov 3, 2020

@pvorb Thank you for reporting this issue, we will review it as soon as possible, thank you!

@Fred-sun Fred-sun added medium_priority Medium priority work in In trying to solve, or in working with contributors labels Nov 3, 2020
@pvorb
Copy link
Author

pvorb commented Mar 4, 2021

Awesome, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority work in In trying to solve, or in working with contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants