Loosen FCP restrictions #188
Conversation
|
Hmm, I'm torn. I agree that the current model is annoying. I'm not sure that majority is sufficient "quorum". I know that I often don't register an objection but also don't click because I want to think -- probably it's good to force me to articulate my concerns though. So 👍 on the idea, probably 👍 on the specifics. |
aturon
force-pushed
the
lazy-consensus
branch
from
e36aa13 to
7a55d7f
Compare
|
I just realized that all this does is ENTER the FCP period. I was concerned about things going "too fast", but that 10 day period is enough time. I say |
!
|
@anp Please hold off on merging until I've heard from the rest of the core team on this -- I'll let you know, |
src/github/nag.rs
Outdated
| @@ -224,6 +224,7 @@ fn evaluate_nags() -> DashResult<()> { | |||
| }; | |||
|
|
|||
| let num_active_reviews = reviews.iter().filter(|&&(_, ref r)| !r.reviewed).count(); | |||
There was a problem hiding this comment.
Maybe this should be renamed to num_outstanding_reviews or num_pending_reviews to contrast it with complete reviews?
src/github/nag.rs
Outdated
| @@ -255,7 +256,7 @@ fn evaluate_nags() -> DashResult<()> { | |||
| }; | |||
| } | |||
|
|
|||
| if num_active_reviews == 0 && num_active_concerns == 0 { | |||
| if (num_active_reviews < num_complete_reviews) && num_active_concerns == 0 { | |||
There was a problem hiding this comment.
We should obviously do whatever works best for the core team, but there are other options here than "all reviewed" or "majority reviewed" like 2/3, all but 1 (to account for people being away), etc.
Allows an item to enter FCP when a majority of team members has approved and *no* team member has objected. This retains the consensus process, but makes it so that FCP isn't blocked *by default*. Rather, members who object to the proposal need to register a concern to block it.
aturon
force-pushed
the
lazy-consensus
branch
from
7a55d7f to
b7b4e3f
Compare
|
Updated per @anp's review, and with the logic that there must be less than 3 reviews outstanding (and a majority must have approved). I think we're good to go on this! |
Allows an item to enter FCP when a majority of team members has approved
and no team member has objected. This retains the consensus process,
but makes it so that FCP isn't blocked by default. Rather, members who
object to the proposal need to register a concern to block it.