Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift revlog count from progress to return value #3070

Closed
dae opened this issue Mar 11, 2024 · 4 comments · Fixed by #3165
Closed

Shift revlog count from progress to return value #3070

dae opened this issue Mar 11, 2024 · 4 comments · Fixed by #3165

Comments

@dae
Copy link
Member

dae commented Mar 11, 2024 

          Sorry for barging in, but I suggest adding the review count to the "Evaluate" window.

image

Originally posted by @Expertium in #3051 (comment)
@Expertium
Copy link
Contributor

I'll elaborate a little more: the number of reviews is displayed when optimization/evaluation is running. However, when this number is small, optimization/evaluation will finish so fast that the user won't even see it.

@dae dae changed the title I suggest adding the review count to the "Evaluate" window. Shift revlog count from progress to return value Mar 12, 2024
@dae
Copy link
Member Author

dae commented Mar 12, 2024

We can do this, but it will mean the count is only shown when the operation completes.

@Expertium
Copy link
Contributor

Why not both?

@dae
Copy link
Member Author

dae commented Mar 13, 2024

Because it's redundant, and requires extra code.

@abdnh abdnh mentioned this issue Apr 24, 2024
Merged
@dae dae closed this as completed in #3165 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show review count with FSRS evaluation results abdnh/anki
2 participants
@dae @Expertium