Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pghero completed 500 internal error throwing plaintext password #483

Closed
kgo-sgo opened this issue Nov 17, 2023 · 2 comments
Closed

pghero completed 500 internal error throwing plaintext password #483

kgo-sgo opened this issue Nov 17, 2023 · 2 comments

Comments

@kgo-sgo
Copy link

kgo-sgo commented Nov 17, 2023

When pghero app does not have access to the postgres instance and gets Completed 500 Internal Server Error then throwing plaintext password to the logs

pghero URI::InvalidURIError (bad URI(is not URI?):
"postgresql://USERNAME:PASSWORD@URL:5432/):

@ankane
Copy link
Owner

ankane commented Nov 17, 2023

Hi @kgo-sgo, thanks for reporting. That error means the URL is malformed / not a valid URL (not that it can't connect). It comes from Ruby / Rails, but it'd be good to try to rescue and re-raise to try to keep a potential password out of the logs.

@ankane
Copy link
Owner

ankane commented Nov 17, 2023

Submitted a PR to Ruby's URI library since I think it's best addressed there: ruby/uri#91

@ankane ankane closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants