Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): autofill value changes not being propagated to the form control #9887

Merged
merged 1 commit into from
Nov 14, 2018
Merged

fix(autocomplete): autofill value changes not being propagated to the form control #9887

merged 1 commit into from
Nov 14, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 11, 2018 •
edited
Loading

Currently we skip any input events on an autocomplete trigger that have been dispatched while the element is blurred, in order to handle some IE-specific cases. This ends up preventing the autocomplete from picking up changes to its value that have come as a result of the browser autofill. These changes move some logic around to handle both autofilling and the IE issues.

Fixes #9704.

@crisbeto crisbeto requested a review from kara as a code owner February 11, 2018 10:06
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 11, 2018
@crisbeto crisbeto force-pushed the 9704/autocomplete-autofill-value branch from 1df05a8 to c946984 Compare February 12, 2018 22:08
jelbourn
jelbourn approved these changes Feb 12, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 12, 2018
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 13, 2018
@MarkPieszak
Copy link
Member

I believe we're seeing some issues from this on iPads (with the latest iOS11) as well.
Do we happen to know which version this PR will get released under by any chance?
@jelbourn @crisbeto

@jelbourn jelbourn added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Mar 7, 2018
@jelbourn
Copy link
Member

jelbourn commented Mar 7, 2018

This currently causes some unit test failures in Google apps that nobody has time to yet investigate.

@josephperrott josephperrott added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Jun 26, 2018
@ngbot
Copy link

ngbot bot commented Jun 29, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto crisbeto force-pushed the 9704/autocomplete-autofill-value branch from c946984 to abaaef1 Compare June 30, 2018 07:53
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Jun 30, 2018
@ngbot
Copy link

ngbot bot commented Jun 30, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure forbidden label detected: presubmit failures
    pending status "ci/circleci: build" is pending
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto
fix(autocomplete): autofill value changes not being propagated to the…
db6e0c2 
… form control

Currently we skip any `input` events on an autocomplete trigger that have been dispatched while the element is blurre, in order to handle some IE-specific cases. This ends up preventing the autocomplete from picking up any changes to its value that have come as a result of the browser autofill. These changes move some logic around to handle both autofilling and the IE issues.

Fixes angular#9704.
@crisbeto crisbeto force-pushed the 9704/autocomplete-autofill-value branch from abaaef1 to db6e0c2 Compare November 13, 2018 21:06
@andrewseguin andrewseguin merged commit 059864d into angular:master Nov 14, 2018
josephperrott pushed a commit that referenced this pull request Nov 19, 2018
@crisbeto @josephperrott
fix(autocomplete): autofill value changes not being propagated to the…
c8592de 
… form control (#9887)

Currently we skip any `input` events on an autocomplete trigger that have been dispatched while the element is blurre, in order to handle some IE-specific cases. This ends up preventing the autocomplete from picking up any changes to its value that have come as a result of the browser autofill. These changes move some logic around to handle both autofilling and the IE issues.

Fixes #9704.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kara kara Awaiting requested review from kara

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mat-autocomplete value not updating with browser autofill
6 participants
@crisbeto @MarkPieszak @jelbourn @googlebot @josephperrott @andrewseguin