Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): not picking up indirect descendant lines #15552

Merged

Conversation

crisbeto
Copy link
Member

Fixes the mat-list-item not picking up mat-line, if it's not a direct descendant.

Fixes #15466.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 20, 2019
@crisbeto crisbeto added G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Mar 20, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 21, 2019
Fixes the `mat-list-item` not picking up `mat-line`, if it's not a direct descendant.

Fixes angular#15466.
@mmalerba mmalerba force-pushed the 15466/list-item-lines-descendants branch from d5f16b0 to a42efc6 Compare April 5, 2019 20:56
@mmalerba mmalerba merged commit a258400 into angular:master Apr 5, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying number of lines in a mat-list-item
4 participants