fix(table): use static queries for examples #15483
Conversation
googlebot
added
the
cla: yes
| @@ -27,8 +30,8 @@ export class TableOverviewExample implements OnInit { | |||
| displayedColumns: string[] = ['id', 'name', 'progress', 'color']; | |||
| dataSource: MatTableDataSource<UserData>; | |||
|
|
|||
| @ViewChild(MatPaginator) paginator: MatPaginator; | |||
| @ViewChild(MatSort) sort: MatSort; | |||
| @ViewChild(MatPaginator, {static: true}) paginator: MatPaginator; | |||
There was a problem hiding this comment.
Couldn't we move the usages to ngAfterViewInit, rather than marking them as static? Since it's an example it won't be a breaking change.
There was a problem hiding this comment.
The issue with the table is that it needs the paginator and sort to figure out the initially rendered rows before initialization. If we wait until after view init, the table will initially render all rows.
There was a problem hiding this comment.
I see, although it's a little unfortunate that we have to require people to use static queries.
crisbeto
added
pr: lgtm
action: merge
mmalerba
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds
{static: true}to any queries in our examples where the query is used in ngOnInit