Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update some static queries in virtual scroll viewport #15346

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

kara
Copy link
Contributor

@kara kara commented Feb 28, 2019

This PR marks some queries as static in CdkVirtualScrollViewport.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 28, 2019
@kara kara changed the title fix(virtual-scroll): move views that are already attached instead of inserting fix: update some static queries in virtual scroll viewport Mar 1, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit fbbd5d0 into angular:ivy-2019 Mar 1, 2019
kara added a commit to kara/material2 that referenced this pull request Mar 7, 2019
kara added a commit to kara/material2 that referenced this pull request Mar 7, 2019
kara added a commit to kara/material2 that referenced this pull request Mar 7, 2019
Suresh918 pushed a commit to Suresh918/material2 that referenced this pull request Apr 15, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants