fix(autocomplete): remove old classes when classlist has changed #15185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have some logic that syncs the classes between the autocomplete host element and the panel, however this logic doesn't account for classes being removed. Fixes angular#15179.
googlebot
added
the
cla: yes
jelbourn
reviewed
Feb 20, 2019
| } | ||
|
|
||
| this._setVisibilityClasses(this._classList); | ||
| this._elementRef.nativeElement.className = ''; |
There was a problem hiding this comment.
I see it was like this before, but doesn't this wipe out .mat-autocomplete?
There was a problem hiding this comment.
It does, but that's the point. This is the element that is left behind in the view after it provides the ng-template for the overlay panel.
diicar
reviewed
Feb 20, 2019
| value.split(' ').forEach(className => this._classList[className.trim()] = true); | ||
| this._elementRef.nativeElement.className = ''; | ||
| this._classList = value.split(' ').reduce((classList, className) => { | ||
| classList[className.trim()] = true; |
There was a problem hiding this comment.
I think the .trim() not needed because of split(' ').
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have some logic that syncs the classes between the autocomplete host element and the panel, however this logic doesn't account for classes being removed.
Fixes #15179.