Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): not updating DOM node name if group name changes #14963

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

crisbeto
Copy link
Member

Fixes the underlying DOM node's name not being in sync with the group, if the group's name is set through the input.

Relates to #14950.

Fixes the underlying DOM node's name not being in sync with the group, if the group's name is set through the input.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 25, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 25, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 29, 2019
@mmalerba mmalerba merged commit fda0c2d into angular:master Jan 30, 2019
mmalerba pushed a commit that referenced this pull request Feb 4, 2019
Fixes the underlying DOM node's name not being in sync with the group, if the group's name is set through the input.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants