-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mat-icon] preventing content from translation #14889
Conversation
adding notranslate class to mat-icon to prevent its content from translation by automated tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test specifically for notranslate
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Caretaker note: commit message to be changed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Prevents translation services (like Google Translate) from translating icon ligatures used in mat-icon.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Current behavior:
to prevent
mat-icon
content from translation by automated tools I'm addingnotranslate
class tomat-icon
by default.PS: I think it makes sense to use this class all the time and not only for font icons since even for svg icons there are only the following use cases:
This why I decided to have less conditions and add class to all icons by default.
From Google Translate FAQ:
