fix(tabs): better handling of animationDuration without units #14778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Jan 10, 2019
src/lib/tabs/tab-group.ts
Outdated
| @Input() | ||
| get animationDuration(): string { return this._animationDuration; } | ||
| set animationDuration(value: string) { | ||
| this._animationDuration = (typeof value === 'number' || !cssUnitPattern.test(value)) ? |
There was a problem hiding this comment.
Is there any reason to not just check that the value matches ^\d+$?
There was a problem hiding this comment.
Good point, that's much more concise. Changed.
Based off of the discussions on angular#13428. Handles values passed to `animationDuration` that don't have units, rather than allowing them to continue through to the `BrowserAnimationsModule` and to throw an error.
crisbeto
force-pushed
the
13428/tabs-animation-duration-units
branch
from
2f2addf to
f1ca702
Compare
jelbourn
added
pr: lgtm
action: merge
s2-abdo
pushed a commit
to s2-abdo/material2
that referenced
this pull request
Jan 18, 2019
…r#14778) Based off of the discussions on angular#13428. Handles values passed to `animationDuration` that don't have units, rather than allowing them to continue through to the `BrowserAnimationsModule` and to throw an error.
s2-abdo
pushed a commit
to s2-abdo/material2
that referenced
this pull request
Jan 18, 2019
…r#14778) Based off of the discussions on angular#13428. Handles values passed to `animationDuration` that don't have units, rather than allowing them to continue through to the `BrowserAnimationsModule` and to throw an error.
vivian-hu-zz
pushed a commit
that referenced
this pull request
Jan 18, 2019
Based off of the discussions on #13428. Handles values passed to `animationDuration` that don't have units, rather than allowing them to continue through to the `BrowserAnimationsModule` and to throw an error.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of the discussions on #13428. Handles values passed to
animationDurationthat don't have units, rather than allowing them to continue through to theBrowserAnimationsModuleand to throw an error.