Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag drop - not dragging in the right direction when element is rotated. #14699

Closed
boradakash opened this issue Jan 2, 2019 · 1 comment · Fixed by #14712
Closed

Drag drop - not dragging in the right direction when element is rotated. #14699

boradakash opened this issue Jan 2, 2019 · 1 comment · Fixed by #14712
Assignees
@crisbeto
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@boradakash
Copy link

boradakash commented Jan 2, 2019 •
edited
Loading

What is the expected behavior?

If the element is rotated then the dragging direction should be in the rotated element's direction

What is the current behavior?

Dragging direction is not rotated with element's direction

What are the steps to reproduce?

I can't find any way to set the dragging direction.
To reproduce the issue, just set rotation on element using transform:rotate(90deg) and then drag the element. It will be placed at the right place but dragging direction is wrong.
Repro link: https://stackblitz.com/edit/angular-ektdw6

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

I am using Angular 7.1.4 and Angular Material 7.2.0

Is there anything else we should know?

You can check the behavior from this link https://gph.is/2R1Aiyu
@crisbeto crisbeto self-assigned this Jan 2, 2019
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Jan 3, 2019
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 3, 2019
@crisbeto
fix(drag-drop): apply translation transform before user transforms
44866a8 
Currently we apply our own transforms after any of the user's transforms, however this can result in some weird behavior if the user defined something like `rotate`. These changes move our values to be first.

Fixes angular#14699.
@crisbeto crisbeto mentioned this issue Jan 3, 2019
Merged
vivian-hu-zz pushed a commit that referenced this issue Jan 16, 2019
@crisbeto @vivian-hu-zz
fix(drag-drop): apply translation transform before user transforms (#…
349675a 
…14712)

Currently we apply our own transforms after any of the user's transforms, however this can result in some weird behavior if the user defined something like `rotate`. These changes move our values to be first.

Fixes #14699.
s2-abdo pushed a commit to s2-abdo/material2 that referenced this issue Jan 18, 2019
@crisbeto @s2-abdo
fix(drag-drop): apply translation transform before user transforms (a…
4e143bc 
…ngular#14712)

Currently we apply our own transforms after any of the user's transforms, however this can result in some weird behavior if the user defined something like `rotate`. These changes move our values to be first.

Fixes angular#14699.
s2-abdo pushed a commit to s2-abdo/material2 that referenced this issue Jan 18, 2019
@crisbeto @s2-abdo
fix(drag-drop): apply translation transform before user transforms (a…
a1022cd 
…ngular#14712)

Currently we apply our own transforms after any of the user's transforms, however this can result in some weird behavior if the user defined something like `rotate`. These changes move our values to be first.

Fixes angular#14699.
vivian-hu-zz pushed a commit that referenced this issue Jan 18, 2019
@crisbeto
fix(drag-drop): apply translation transform before user transforms (#…
7322977 
…14712)

Currently we apply our own transforms after any of the user's transforms, however this can result in some weird behavior if the user defined something like `rotate`. These changes move our values to be first.

Fixes #14699.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(drag-drop): apply translation transform before user transforms crisbeto/material2
2 participants
@crisbeto @boradakash