fix(table): not re-rendering when switching to a smaller set of data than the current page #14665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
…than the current page Fixes the table not rendering correctly when going from a large set of data (e.g. 50 items and on page 10) to a small set of items (e.g. 1 item). The issue comes from the fact that the paginator doesn't emit events if they weren't generated by the user (see discussion on angular#12586). Fixes angular#14010.
crisbeto
force-pushed
the
14010/table-paginator-smaller-data
branch
from
07849e4 to
68c9d8c
Compare
andrewseguin
added
pr: lgtm
action: merge
andrewseguin
approved these changes
Jan 9, 2019
| @@ -276,14 +280,24 @@ export class MatTableDataSource<T> extends DataSource<T> { | |||
| */ | |||
| _updatePaginator(filteredDataLength: number) { | |||
| Promise.resolve().then(() => { | |||
| if (!this.paginator) { return; } | |||
| const paginator = this.paginator; | |||
There was a problem hiding this comment.
Why are we creating a new const for this?
There was a problem hiding this comment.
We were using this.paginator in 4-5 different places. I moved it out into a const because it minifies better.
s2-abdo
pushed a commit
to s2-abdo/material2
that referenced
this pull request
Jan 18, 2019
…than the current page (angular#14665) Fixes the table not rendering correctly when going from a large set of data (e.g. 50 items and on page 10) to a small set of items (e.g. 1 item). The issue comes from the fact that the paginator doesn't emit events if they weren't generated by the user (see discussion on angular#12586). Fixes angular#14010.
s2-abdo
pushed a commit
to s2-abdo/material2
that referenced
this pull request
Jan 18, 2019
…than the current page (angular#14665) Fixes the table not rendering correctly when going from a large set of data (e.g. 50 items and on page 10) to a small set of items (e.g. 1 item). The issue comes from the fact that the paginator doesn't emit events if they weren't generated by the user (see discussion on angular#12586). Fixes angular#14010.
vivian-hu-zz
pushed a commit
that referenced
this pull request
Jan 18, 2019
…than the current page (#14665) Fixes the table not rendering correctly when going from a large set of data (e.g. 50 items and on page 10) to a small set of items (e.g. 1 item). The issue comes from the fact that the paginator doesn't emit events if they weren't generated by the user (see discussion on #12586). Fixes #14010.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the table not rendering correctly when going from a large set of data (e.g. 50 items and on page 10) to a small set of items (e.g. 1 item). The issue comes from the fact that the paginator doesn't emit events if they weren't generated by the user (see discussion on #12586).
Fixes #14010.