Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drag drop- item remains connected to drop list when drop not released #14645

Closed
WJ89 opened this issue Dec 27, 2018 · 2 comments · Fixed by #14651
Closed

drag drop- item remains connected to drop list when drop not released #14645

WJ89 opened this issue Dec 27, 2018 · 2 comments · Fixed by #14651
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@WJ89
Copy link

WJ89 commented Dec 27, 2018

What is the expected behavior?

When an multiple drop lists available, a draggable item should be able to be dragged across one list and into another

What is the current behavior?

Once an item is dragged over a drop list it must be returned to it's original list before it can be dropped in another

What are the steps to reproduce?

https://stackblitz.com/edit/angular-yp3lzk
If you drag from the "Drag Me" list over "Drop list 1" you can't drop in "Drop List 2" until you bring the item back over the "Drag Me" list

@crisbeto crisbeto self-assigned this Dec 27, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 27, 2018
…ng through another container

Fixes not being able to move an item from one container into another by passing it through an intermediate container that isn't connected to the final one. The issue comes from the fact that the way things are set up at the moment, the container from which the item started the sequence knows which containers it can go into, however all that knowledge is reset once the item enters into a different container. These changes rework the logic to have the individual containers know whether the item can enter into them and have the source container "ask" each of its siblings whether the item can enter.

Fixes angular#14645.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Dec 27, 2018
@WJ89
Copy link
Author

WJ89 commented Dec 28, 2018

Thanks Kristiyan!

vivian-hu-zz pushed a commit that referenced this issue Jan 16, 2019
…ng through another container (#14651)

Fixes not being able to move an item from one container into another by passing it through an intermediate container that isn't connected to the final one. The issue comes from the fact that the way things are set up at the moment, the container from which the item started the sequence knows which containers it can go into, however all that knowledge is reset once the item enters into a different container. These changes rework the logic to have the individual containers know whether the item can enter into them and have the source container "ask" each of its siblings whether the item can enter.

Fixes #14645.
s2-abdo pushed a commit to s2-abdo/material2 that referenced this issue Jan 18, 2019
…ng through another container (angular#14651)

Fixes not being able to move an item from one container into another by passing it through an intermediate container that isn't connected to the final one. The issue comes from the fact that the way things are set up at the moment, the container from which the item started the sequence knows which containers it can go into, however all that knowledge is reset once the item enters into a different container. These changes rework the logic to have the individual containers know whether the item can enter into them and have the source container "ask" each of its siblings whether the item can enter.

Fixes angular#14645.
s2-abdo pushed a commit to s2-abdo/material2 that referenced this issue Jan 18, 2019
…ng through another container (angular#14651)

Fixes not being able to move an item from one container into another by passing it through an intermediate container that isn't connected to the final one. The issue comes from the fact that the way things are set up at the moment, the container from which the item started the sequence knows which containers it can go into, however all that knowledge is reset once the item enters into a different container. These changes rework the logic to have the individual containers know whether the item can enter into them and have the source container "ask" each of its siblings whether the item can enter.

Fixes angular#14645.
vivian-hu-zz pushed a commit that referenced this issue Jan 18, 2019
…ng through another container (#14651)

Fixes not being able to move an item from one container into another by passing it through an intermediate container that isn't connected to the final one. The issue comes from the fact that the way things are set up at the moment, the container from which the item started the sequence knows which containers it can go into, however all that knowledge is reset once the item enters into a different container. These changes rework the logic to have the individual containers know whether the item can enter into them and have the source container "ask" each of its siblings whether the item can enter.

Fixes #14645.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
2 participants