feat(tabs): add automatic scrolling when holding down paginator #14632
Conversation
googlebot
added
the
cla: yes
| (click)="_scrollHeader('before')"> | ||
| (click)="_handlePaginatorClick('before')" | ||
| (mousedown)="_handlePaginatorPress('before')" | ||
| (touchend)="_stopInterval()"> |
There was a problem hiding this comment.
Why the mix of mousedown and touchend?
There was a problem hiding this comment.
The touchend is there to clear the interval in case the mousedown doesn't fire since it behaves closer to a click on touch devices.
| @@ -230,9 +271,25 @@ export class MatTabHeader extends _MatTabHeaderMixinBase | |||
| }); | |||
| } | |||
|
|
|||
| ngAfterViewInit() { | |||
| // We need to handle these events manually, because we want to bind passive event listeners. | |||
There was a problem hiding this comment.
I'd expand the comment like
// Register event handlers for scrolling tabs while holding down the pagination buttons.
// We register these events manually because we want to bind *passive* event listeners.| @@ -469,4 +529,49 @@ export class MatTabHeader extends _MatTabHeaderMixinBase | |||
|
|
|||
| this._inkBar.alignToElement(selectedLabelWrapper!); | |||
| } | |||
|
|
|||
| /** Stops the currently-running paginator interval. */ | |||
| _stopInterval() { | |||
There was a problem hiding this comment.
_stopPaginationScrollInterval?
crisbeto
force-pushed
the
6510/tabs-auto-scroll
branch
2 times, most recently
from
ff70154 to
9450e37
Compare
|
I've addressed the feedback @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
crisbeto
force-pushed
the
6510/tabs-auto-scroll
branch
from
9450e37 to
0e795e8
Compare
|
@crisbeto Looks like the API golden check failed - can you update the API |
Adds some code that automatically keeps scrolling the tab header while holding down one of the paginator buttons. This is useful on long lists of tabs where the user might have to click a lot to reach the tab that they want. Fixes angular#6510.
crisbeto
force-pushed
the
6510/tabs-auto-scroll
branch
from
0e795e8 to
8cf20da
Compare
|
Updated the goldens. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds some code that automatically keeps scrolling the tab header while holding down one of the paginator buttons. This is useful on long lists of tabs where the user might have to click a lot to reach the tab that they want.
Fixes #6510.