-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two consecutive commas generated with nav schematics #14366
Labels
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Comments
@klemenoslaj Please feel free to do. Otherwise I can just take care of it. Also have a look for the other schematics as those can have the same problem. |
This was referenced Dec 3, 2018
mmalerba
pushed a commit
that referenced
this issue
Dec 3, 2018
When generating any Material schematic with OnPush changeDetection, we get two consecutive commas in component decorator. Fixes: #14366
mmalerba
pushed a commit
that referenced
this issue
Dec 10, 2018
When generating any Material schematic with OnPush changeDetection, we get two consecutive commas in component decorator. Fixes: #14366
josephperrott
pushed a commit
to josephperrott/components
that referenced
this issue
Jan 14, 2019
When generating any Material schematic with OnPush changeDetection, we get two consecutive commas in component decorator. Fixes: angular#14366
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Bug, feature request, or proposal:
Bug
What is the expected behavior?
Generating nav using material schematics should generate valid TypeScript code.
What is the current behavior?
When generating the nav with OnPush changeDetection we get two consecutive commas.
What are the steps to reproduce?
Execute the following command in Angular workspace:
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular CLI: 7.1.0
Node: 10.13.0
OS: darwin x64
Angular: 7.1.0
... animations, bazel, common, compiler, compiler-cli, core
... elements, forms, http, platform-browser
... platform-browser-dynamic, platform-server, router
Package Version
@angular-devkit/architect 0.10.6
@angular-devkit/core 7.0.6
@angular-devkit/schematics 7.0.6
@schematics/angular 7.0.6
@schematics/update 0.11.0 (cli-only)
rxjs 6.3.3
typescript 3.1.1
Is there anything else we should know?
I would be filling to submit my first pull request to fix this issue.
The text was updated successfully, but these errors were encountered: