-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(slide-toggle): label not being read out by screen reader on IE #14259
Conversation
Fixes the label of a slide toggle not being read out by NVDA on IE, because the `label` element isn't pointing to the `input`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically the input wrapped inside of a <label>
should be automatically associated with the label. Nevertheless, being explicit doesn't hurt. LGTM
Yeah wrapping it should be enough, but it doesn't look like that's the case in IE. We've been doing the same in checkbox and radio already. |
…14259) Fixes the label of a slide toggle not being read out by NVDA on IE, because the `label` element isn't pointing to the `input`.
…ngular#14259) Fixes the label of a slide toggle not being read out by NVDA on IE, because the `label` element isn't pointing to the `input`.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes the label of a slide toggle not being read out by NVDA on IE, because the
label
element isn't pointing to theinput
.