Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): unable to disable ripple on datepicker toggle #13997

Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 5, 2018

Allows for the ripple on the datepicker toggle to be disabled.

Fixes #13986.

Note that these changes don't use the mixin for disabling ripples, because it isn't necessary since it is implemented by the underlying mat-button already.

Allows for the ripple on the datepicker toggle to be disabled.

Fixes angular#13986.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 5, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner November 5, 2018 22:56
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 5, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 6, 2018
@vivian-hu-zz vivian-hu-zz merged commit 31bffb3 into angular:master Nov 7, 2018
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
Allows for the ripple on the datepicker toggle to be disabled.

Fixes #13986.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matRippleDisabled at mat-datepicker-toggle
5 participants