fix(drag-drop): error if drag item is destroyed before the zone has stabilized #13978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We initialize the `rootElement` in an `NgZone.onStable` callback, however if the zone doesn't stabilize before the `cdkDrag` is destroyed, we'll throw an error because there is no `rootElement`. These changes add an extra check to ensure that we don't throw.
googlebot
added
the
cla: yes
crisbeto
changed the title
jelbourn
reviewed
Nov 5, 2018
| rootElement.addEventListener('touchstart', this._pointerDown, passiveEventListenerOptions); | ||
| toggleNativeDragInteractions(rootElement , false); | ||
| }); | ||
| this._rootElementInitSubscription = this._ngZone.onStable.asObservable() |
There was a problem hiding this comment.
Could to use takeUntil with _destroyed subject here?
There was a problem hiding this comment.
I could, but then we'd have the _destroyed only for this one case.
jelbourn
approved these changes
Nov 5, 2018
vivian-hu-zz
pushed a commit
that referenced
this pull request
Nov 12, 2018
…13978) We initialize the `rootElement` in an `NgZone.onStable` callback, however if the zone doesn't stabilize before the `cdkDrag` is destroyed, we'll throw an error because there is no `rootElement`. These changes add an extra check to ensure that we don't throw.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We initialize the
rootElementin anNgZone.onStablecallback, however if the zone doesn't stabilize before thecdkDragis destroyed, we'll throw an error because there is norootElement. These changes add an extra check to ensure that we don't throw.