Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk-platform): pass {} to @NgModule since passing nothing breaks in JIT mode #13792

Merged
merged 1 commit into from
Oct 24, 2018
Merged

fix(cdk-platform): pass {} to @NgModule since passing nothing breaks in JIT mode #13792

merged 1 commit into from
Oct 24, 2018

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release labels Oct 24, 2018
@mmalerba mmalerba requested review from jelbourn and crisbeto October 24, 2018 15:31
@mmalerba mmalerba requested a review from devversion as a code owner October 24, 2018 15:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 24, 2018
devversion
devversion approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 24, 2018
crisbeto
crisbeto reviewed Oct 24, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment that it’s necessary?

@mmalerba mmalerba merged commit 65dd75d into angular:master Oct 24, 2018
mmalerba added a commit that referenced this pull request Oct 26, 2018
@mmalerba
fix(cdk-platform): pass {} to @NgModule since passing nothing bre…
5abb644 
…aks (#13792)

in JIT mode
crisbeto added a commit to crisbeto/material2 that referenced this pull request Oct 27, 2018
@crisbeto
build: add tooling to avoid jit issues with empty NgModule definitions
9014231 
* Expands the decorator validation rule to allow us to run a regex against all the arguments of a decorator. This allows us to guard against cases like angular#13792.
* Fixes a similar issue as angular#13792 in the `LayoutModule` which was caught after the new changes to the rule.
@crisbeto crisbeto mentioned this pull request Oct 27, 2018
Merged
jelbourn pushed a commit that referenced this pull request Oct 30, 2018
@crisbeto @jelbourn
build: add tooling to avoid jit issues with empty NgModule definitions (
d0f0f0a 
#13843)

* Expands the decorator validation rule to allow us to run a regex against all the arguments of a decorator. This allows us to guard against cases like #13792.
* Fixes a similar issue as #13792 in the `LayoutModule` which was caught after the new changes to the rule.
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
@mmalerba @atscott
fix(cdk-platform): pass {} to @NgModule since passing nothing bre…
ab6b7bd 
…aks (angular#13792)

in JIT mode
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
@crisbeto @atscott
build: add tooling to avoid jit issues with empty NgModule definitions (
53d7bcc 
angular#13843)

* Expands the decorator validation rule to allow us to run a regex against all the arguments of a decorator. This allows us to guard against cases like angular#13792.
* Fixes a similar issue as angular#13792 in the `LayoutModule` which was caught after the new changes to the rule.
jelbourn pushed a commit that referenced this pull request Nov 6, 2018
@crisbeto @jelbourn
build: add tooling to avoid jit issues with empty NgModule definitions (
1eefe5f 
#13843)

* Expands the decorator validation rule to allow us to run a regex against all the arguments of a decorator. This allows us to guard against cases like #13792.
* Fixes a similar issue as #13792 in the `LayoutModule` which was caught after the new changes to the rule.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmalerba @crisbeto @devversion @jelbourn @googlebot