Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stepper): selector assuming that there will always be a dir attribute #13751

Merged
merged 1 commit into from
Oct 23, 2018
Merged

fix(stepper): selector assuming that there will always be a dir attribute #13751

merged 1 commit into from
Oct 23, 2018

Conversation

crisbeto
Copy link
Member

One of the selectors in the step header assumes that there will be at least one parent with a dir="ltr" or dir="rtl". These changes rework it to have LTR as the base.

Fixes #13741.

@crisbeto
fix(stepper): selector assuming that there will always be a dir attri…
b540104 
…bute

One of the selectors in the step header assumes that there will be at least one parent with a `dir="ltr"` or `dir="rtl"`. These changes rework it to have LTR as the base.

Fixes angular#13741.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 22, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner October 22, 2018 17:56
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 22, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 22, 2018
@mmalerba mmalerba merged commit d5f0f0f into angular:master Oct 23, 2018
mmalerba pushed a commit that referenced this pull request Oct 26, 2018
@crisbeto @mmalerba
fix(stepper): selector assuming that there will always be a dir attri…
576118e 
…bute (#13751)

One of the selectors in the step header assumes that there will be at least one parent with a `dir="ltr"` or `dir="rtl"`. These changes rework it to have LTR as the base.

Fixes #13741.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(stepper) labelPosition wrong GUI if 'dir' attribute is missing
3 participants
@crisbeto @googlebot @mmalerba