Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ng add @angular/material asks to choose theme, but there is no way to preview it #13708

Closed
filipesilva opened this issue Oct 20, 2018 · 2 comments · Fixed by #13723
Closed

ng add @angular/material asks to choose theme, but there is no way to preview it #13708

filipesilva opened this issue Oct 20, 2018 · 2 comments · Fixed by #13723
Assignees
@crisbeto
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix

Comments

@filipesilva
Copy link
Contributor

Bug, feature request, or proposal:

When using ng add @angular/material, a user will be prompted to choose a theme:
image

It is hard to make an informed decision about which theme to choose because neither https://material.angular.io/guide/getting-started#step-4-include-a-theme nor https://material.angular.io/guide/theming offer a preview of these themes.

The material docs seem to have a theme picker themselves, but offer no indication of the theme name or whether those four are the same as the choose offered in the prompt:
image

What is the expected behavior?

There should be a way to preview what the themes that a user is selecting.

What is the current behavior?

A user is asked to choose the theme they have no way of differentiating.

What are the steps to reproduce?

ng new my-material-app
cd my-material-app
ng add @angular/material

What is the use-case or motivation for changing an existing behavior?

Providing a user the necessary background in order to make a decision requested by the prompts.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 7 (Angular/Material/CLI)

Is there anything else we should know?
@filipesilva
Copy link
Contributor Author

It would also be helpful to mention which themes are light and which are dark, as that affects how examples will look like when using the docs.

crisbeto added a commit to crisbeto/material.angular.io that referenced this issue Oct 21, 2018
@crisbeto
feat: add the ability to link to the site with a particular theme
f6b5f84 
* Reworks the theming setup to store only the current theme's name, rather than the entire object in `localStorage`. This is more robust for the cases where we want to change the theme object's interface.
* Adds the ability to link people to the docs site with a particular theme (e.g. https://material.angular.io?theme=purple-green). This allows us to preview the theme. For example we can use it for angular/components#13708 to show people what the theme would look like when they're prompted in a schematic.
@crisbeto crisbeto mentioned this issue Oct 21, 2018
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 21, 2018
@crisbeto
feat(ng-add): add preview URLs for theme choices
071aea2 
Adds URLs that people can use to preview a theme, before selecting it, when going through the ng-add prompts.
Formatting is aligned with https://github.com/angular/angular-cli/blob/907ce5c94c774147c4b52870b3522aed4e087c76/packages/schematics/angular/ng-new/schema.json#L121

Fixes angular#13708.
@crisbeto crisbeto mentioned this issue Oct 21, 2018
Merged
@crisbeto crisbeto self-assigned this Oct 21, 2018
@crisbeto crisbeto added feature This issue represents a new feature or feature request rather than a bug or bug fix has pr labels Oct 21, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 21, 2018
@crisbeto
feat(ng-add): add preview URLs for theme choices
81c0de0 
Adds URLs that people can use to preview a theme, before selecting it, when going through the ng-add prompts.
Formatting is aligned with https://github.com/angular/angular-cli/blob/907ce5c94c774147c4b52870b3522aed4e087c76/packages/schematics/angular/ng-new/schema.json#L121

Fixes angular#13708.
jelbourn pushed a commit to angular/material.angular.io that referenced this issue Oct 24, 2018
@crisbeto @jelbourn
feat: add the ability to link to the site with a particular theme (#549)
80addca 
* Reworks the theming setup to store only the current theme's name, rather than the entire object in `localStorage`. This is more robust for the cases where we want to change the theme object's interface.
* Adds the ability to link people to the docs site with a particular theme (e.g. https://material.angular.io?theme=purple-green). This allows us to preview the theme. For example we can use it for angular/components#13708 to show people what the theme would look like when they're prompted in a schematic.
mmalerba pushed a commit that referenced this issue Oct 25, 2018
@crisbeto @mmalerba
feat(ng-add): add preview URLs for theme choices (#13723)
4fbbb9d 
Adds URLs that people can use to preview a theme, before selecting it, when going through the ng-add prompts.
Formatting is aligned with https://github.com/angular/angular-cli/blob/907ce5c94c774147c4b52870b3522aed4e087c76/packages/schematics/angular/ng-new/schema.json#L121

Fixes #13708.

**A couple of notes:**
* Blocked until angular/material.angular.io#549 is merged and released.
* Marking this as `patch`, even though it's a `feat`, since it's basically just message changes.
mmalerba pushed a commit that referenced this issue Oct 26, 2018
@crisbeto @mmalerba
feat(ng-add): add preview URLs for theme choices (#13723)
f1d1fc5 
Adds URLs that people can use to preview a theme, before selecting it, when going through the ng-add prompts.
Formatting is aligned with https://github.com/angular/angular-cli/blob/907ce5c94c774147c4b52870b3522aed4e087c76/packages/schematics/angular/ng-new/schema.json#L121

Fixes #13708.

**A couple of notes:**
* Blocked until angular/material.angular.io#549 is merged and released.
* Marking this as `patch`, even though it's a `feat`, since it's basically just message changes.
atscott pushed a commit to atscott/components that referenced this issue Nov 5, 2018
@crisbeto @atscott
feat(ng-add): add preview URLs for theme choices (angular#13723)
e33019f 
Adds URLs that people can use to preview a theme, before selecting it, when going through the ng-add prompts.
Formatting is aligned with https://github.com/angular/angular-cli/blob/907ce5c94c774147c4b52870b3522aed4e087c76/packages/schematics/angular/ng-new/schema.json#L121

Fixes angular#13708.

**A couple of notes:**
* Blocked until angular/material.angular.io#549 is merged and released.
* Marking this as `patch`, even though it's a `feat`, since it's basically just message changes.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ng-add): add preview URLs for theme choices crisbeto/material2
2 participants
@filipesilva @crisbeto