Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schematics): template content exceeds max line length #13521

Merged
merged 1 commit into from
Oct 10, 2018
Merged

fix(schematics): template content exceeds max line length #13521

merged 1 commit into from
Oct 10, 2018

Conversation

devversion
Copy link
Member

  • Assuming most of the CLI projects have the line limit at around 100, one line within the address-form TS template file exceeds this average max-line-length boundary by 17.

@devversion
fix(schematics): template content exceeds max line length
d6c62e9 
* Assuming most of the CLI projects have the line limit at around `100`, one line within the `address-form` TS template file exceeds this average max-line-length boundary by `17`.
@devversion devversion added pr: merge safe target: major This PR is targeted for the next major release labels Oct 9, 2018
@devversion devversion requested a review from jelbourn as a code owner October 9, 2018 19:49
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 9, 2018
jelbourn
jelbourn approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 10, 2018
@andrewseguin andrewseguin merged commit b0a1daf into angular:master Oct 10, 2018
@devversion devversion deleted the fix/schematics-max-line-length-address-form branch October 10, 2018 18:29
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@devversion @roboshoes
fix(schematics): template content exceeds max line length (angular#13521
f293143 
)

* Assuming most of the CLI projects have the line limit at around `100`, one line within the `address-form` TS template file exceeds this average max-line-length boundary by `17`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @andrewseguin