Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mat-checkbox Ripple animation not closing while check and uncheck the box. @7.0.0-beta.2. #13291

Closed
rohit1018 opened this issue Sep 24, 2018 · 1 comment · Fixed by #13295
Closed

mat-checkbox Ripple animation not closing while check and uncheck the box. @7.0.0-beta.2. #13291

rohit1018 opened this issue Sep 24, 2018 · 1 comment · Fixed by #13295
Assignees
@devversion
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@rohit1018
Copy link

Bug, feature request, or proposal:

(Bug): Ripple animation not closing while check and uncheck the box.

What is the expected behavior?

Ripple animation will be smooth while check and uncheck the box.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

"@angular/material": "^7.0.0-beta.2"
uncheck ripple
check ripple
@devversion devversion self-assigned this Sep 24, 2018
@devversion devversion added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Sep 24, 2018
devversion added a commit to devversion/material2 that referenced this issue Sep 24, 2018
@devversion
fix(checkbox): ripple not hiding after click/touch
e417570 
* Currently if someone toggles the slide-toggle through mouse interaction, the persistent ripple will show up besides one transient ripple. The persistent ripple should only show up if the native checkbox element was focused through keyboard.

Fixes angular#13291
@devversion devversion mentioned this issue Sep 24, 2018
Merged
vivian-hu-zz pushed a commit that referenced this issue Oct 4, 2018
@devversion @vivian-hu-zz
fix(checkbox): ripple not hiding after click/touch (#13295)
afb0352 
* Currently if someone toggles the slide-toggle through mouse interaction, the persistent ripple will show up besides one transient ripple. The persistent ripple should only show up if the native checkbox element was focused through keyboard.

Fixes #13291
roboshoes pushed a commit to roboshoes/material2 that referenced this issue Oct 23, 2018
@devversion @roboshoes
fix(checkbox): ripple not hiding after click/touch (angular#13295)
85ed51b 
* Currently if someone toggles the slide-toggle through mouse interaction, the persistent ripple will show up besides one transient ripple. The persistent ripple should only show up if the native checkbox element was focused through keyboard.

Fixes angular#13291
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(checkbox): ripple not hiding after click/touch devversion/material2
2 participants
@devversion @rohit1018