Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-field): not updating outline when prefix/suffix is added or removed #13253

Merged

Conversation

crisbeto
Copy link
Member

Fixes the form field's outline not reacting to the prefix/suffix being toggled after init.

Fixes #13251.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Sep 22, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner September 22, 2018 08:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 22, 2018
…removed

Fixes the form field's outline not reacting to the prefix/suffix being toggled after init.

Fixes angular#13251.
@crisbeto crisbeto force-pushed the 13251/form-field-prefix-change-recalc branch from f4112be to d588d93 Compare September 22, 2018 09:45
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 24, 2018
@vivian-hu-zz vivian-hu-zz merged commit 0060bd7 into angular:master Oct 5, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
…removed (angular#13253)

Fixes the form field's outline not reacting to the prefix/suffix being toggled after init.

Fixes angular#13251.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input Outline floating label gap didn't get re-calculated on prefix hide
4 participants