Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete: Add support for dividers in options list #13200

Closed
kseamon opened this issue Sep 19, 2018 · 3 comments · Fixed by #13224
Closed

Autocomplete: Add support for dividers in options list #13200

kseamon opened this issue Sep 19, 2018 · 3 comments · Fixed by #13224
Assignees
@crisbeto
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@kseamon
Copy link
Collaborator

kseamon commented Sep 19, 2018

Bug, feature request, or proposal:

Feature request

What is the expected behavior?

Support for dividers in the Autocomplete popup

What is the current behavior?

Not supported

What are the steps to reproduce?

Providing a StackBlitz reproduction is the best way to share your issue.

StackBlitz starter: https://goo.gl/wwnhMV

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Is there anything else we should know?
@jelbourn jelbourn added feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent G This is is related to a Google internal issue labels Sep 19, 2018
@jelbourn
Copy link
Member

@crisbeto do you think this would be relatively straightforward?

crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 20, 2018
@crisbeto
fix(autocomplete): dividers in list throwing off keyboard navigation
1d4f591 
Since we count on the options being a particular height, having 1px dividers between them ends up throwing off the keyboard navigation. These changes add an offset to the dividers to avoid the issue.

Fixes angular#13200.
@crisbeto crisbeto mentioned this issue Sep 20, 2018
Merged
@crisbeto
Copy link
Member

@kseamon you can use mat-divider inside mat-autocomplete already, but you'll have to set margin-top: -1px on it yourself to avoid issues with the keyboard scrolling. I've submitted #13224 to handle it from Material.

vivian-hu-zz pushed a commit that referenced this issue Oct 2, 2018
@crisbeto @vivian-hu-zz
fix(autocomplete): dividers in list throwing off keyboard navigation (#…
0886cef 
…13224)

Since we count on the options being a particular height, having 1px dividers between them ends up throwing off the keyboard navigation. These changes add an offset to the dividers to avoid the issue.

Fixes #13200.
roboshoes pushed a commit to roboshoes/material2 that referenced this issue Oct 23, 2018
@crisbeto @roboshoes
fix(autocomplete): dividers in list throwing off keyboard navigation (a…
a8020f6 
…ngular#13224)

Since we count on the options being a particular height, having 1px dividers between them ends up throwing off the keyboard navigation. These changes add an offset to the dividers to avoid the issue.

Fixes angular#13200.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(autocomplete): dividers in list throwing off keyboard navigation crisbeto/material2
3 participants
@jelbourn @kseamon @crisbeto