Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(@angular/cdk/drag-drop) broken sorting on preview and after drop on webkit browsers (Chrome, Opera) #13072

Closed
krzychu124 opened this issue Sep 11, 2018 · 1 comment · Fixed by #13082
Closed

bug(@angular/cdk/drag-drop) broken sorting on preview and after drop on webkit browsers (Chrome, Opera) #13072

krzychu124 opened this issue Sep 11, 2018 · 1 comment · Fixed by #13082
Assignees
@crisbeto
Labels
animation This issue is related to Angular animations or CSS animations P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@krzychu124
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Item preview should be drawn correctly, and item should be placed according to location at preview

What is the current behavior?

v6.4.7 (smooth animations, broken sorting)
drag-drop-6 4 7-stable

v7.0.0-beta.0 (partial animations, broken sorting)
drag-drop

Item preview and action after drop not working under some conditions.
It looks like it's related to item count, because bug occurs when item count in list exceeds 10 elements.

What are the steps to reproduce?

Run demo-app inside this project with changed horizontalData array content
src/demo-app/drag-drop/drag-drop.ts:
horizontalData = [ '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10' ];
and try drag and drop items in horizontal list

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Demo app inside this project - build v6.4.7 and v7.0.0-beta.0,
Webkit browsers: Chrome, Opera

Is there anything else we should know?

I've tested it on various web browsers:
-working on Edge 41.16299.611.0 and Mozilla 62.0 (64bit),
-broken on Chrome 69.0.3497.81 and Opera 55.0.2994.56, Chrome on Android 68.0.3440.91
@josephperrott josephperrott added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent animation This issue is related to Angular animations or CSS animations labels Sep 11, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 11, 2018
@crisbeto
fix(drag-drop): incorrectly calculating index when sorting horizontally
1e17012 
Fixes the list index not being calculated correctly, because the items are being sorted in memory based on their `top` position, even though the dragging is horizontal.

Fixes angular#13072.
@crisbeto crisbeto mentioned this issue Sep 11, 2018
Merged
jelbourn pushed a commit that referenced this issue Sep 11, 2018
@crisbeto @jelbourn
fix(drag-drop): incorrectly calculating index when sorting horizontal…
664ef4c 
…ly (#13082)

Fixes the list index not being calculated correctly, because the items are being sorted in memory based on their `top` position, even though the dragging is horizontal.

Fixes #13072.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
animation This issue is related to Angular animations or CSS animations P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(drag-drop): incorrectly calculating index when sorting horizontally crisbeto/material2
3 participants
@crisbeto @josephperrott @krzychu124