Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ripple): ripples not being cleared if touch sequence is canceled #12936

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 1, 2018

If the browser's touch sequence gets canceled by something, the touchend event won't fire which means that the ripples won't be cleared from the ripple container. These changes add an extra handler to make sure that they are.

If the browser's touch sequence gets canceled by something, the `touchend` event won't fire which means that the ripples won't be cleared from the ripple container. These changes add an extra handler to make sure that they are.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Sep 1, 2018
@crisbeto crisbeto requested a review from devversion as a code owner September 1, 2018 12:32
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 1, 2018
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 1, 2018
@jelbourn jelbourn merged commit 948e563 into angular:master Sep 11, 2018
jelbourn pushed a commit that referenced this pull request Sep 11, 2018
…12936)

If the browser's touch sequence gets canceled by something, the `touchend` event won't fire which means that the ripples won't be cleared from the ripple container. These changes add an extra handler to make sure that they are.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants