Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expansion): disable all animations when using NoopAnimationsModule #12855

Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 27, 2018

Disables all of the expansion panel animations if it's inside a module with the NoopAnimationsModule. Also removes the mat-elevation-transition from the expansion panel, because it hasn't been doing anything for a while since it gets overwritten by the margin transition below.

Relates to #10590.

Note: this is a resubmit of #11576 which got messed up while rebasing.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Aug 27, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 27, 2018
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 27, 2018
@ngbot
Copy link

ngbot bot commented Aug 27, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing
    pending status "ci/circleci: build" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Disables all of the expansion panel animations if it's inside a module with the NoopAnimationsModule. Also removes the mat-elevation-transition from the expansion panel, because it hasn't been doing anything for a while since it gets overwritten by the margin transition below.

Relates to angular#10590.
@crisbeto crisbeto force-pushed the 10590/expansion-panel-noop-animations-again branch from a8430c5 to 8b14eff Compare August 27, 2018 19:47
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 3e22641 into angular:master Sep 14, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants