Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): add minDate and maxDate validation in demo-app #12531

Merged

Conversation

Nevaan
Copy link
Contributor

@Nevaan Nevaan commented Aug 4, 2018

Adds min and max properties for datepicker input for purposes of validation. After this change, it will not be possible to set invalid period of time.

Fixes #12442

Adds min and max properties for datepicker input for purposes of validation. After this change, it will not be possible to set invalid period of time.

Fixes angular#12442
@Nevaan Nevaan requested a review from mmalerba as a code owner August 4, 2018 21:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 4, 2018
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker pr: merge safe labels Aug 6, 2018
@ngbot
Copy link

ngbot bot commented Aug 6, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required label: "target: *"
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba
Copy link
Contributor

mmalerba commented Aug 6, 2018

Thanks for the fix!

@josephperrott josephperrott merged commit 2b29c93 into angular:master Aug 7, 2018
@Nevaan Nevaan deleted the datepicker-example-date-validation branch August 27, 2018 17:09
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo: Min date later than max date improper behavior
4 participants