From 0065b53e897a0370cb0a869813b5a80c5ecb93c5 Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Mon, 13 Sep 2021 15:36:35 -0700 Subject: [PATCH] fixup! feat(ng-dev/release): add marker between generated changelog entries --- ng-dev/release/notes/changelog.ts | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/ng-dev/release/notes/changelog.ts b/ng-dev/release/notes/changelog.ts index 469a6f0e0b..3cd593adda 100644 --- a/ng-dev/release/notes/changelog.ts +++ b/ng-dev/release/notes/changelog.ts @@ -50,11 +50,11 @@ export class Changelog { */ private get archiveEntries() { if (this._archiveEntries === undefined) { - return this._archiveEntries = this.getEntriesFor(this.archiveFilePath); + return (this._archiveEntries = this.getEntriesFor(this.archiveFilePath)); } return this._archiveEntries; } - private _archiveEntries: undefined | ChangelogEntry[] = undefined + private _archiveEntries: undefined | ChangelogEntry[] = undefined; /** Whether the changelog archive has entries upon intialization. */ private alreadyHasChangelogArchive = this.archiveEntries.length !== 0; @@ -69,6 +69,11 @@ export class Changelog { /** * Move all changelog entries from the CHANGELOG.md file for versions prior to the provided * version to the changelog archive. + * + * Versions should be used to determine which entries are moved to archive as versions are the + * most accurate piece of context found within a changelog entry to determine its relationship to + * other changelog entries. This allows for example, moving all changelog entries out of the + * main changelog when a version moves out of support. */ moveEntriesPriorToVersionToArchive(version: semver.SemVer) { [...this.entries].reverse().forEach((entry: ChangelogEntry) => {