fix(text-field): correctly check _initialHeight #17900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mprobst
force-pushed
the
initialHeight
branch
from
5c2208c to
22e0c74
Compare
TypeScript 3.7 flags the assignment on line 250 because `style.height` must not be `null`. The underlying reason though appears to be that the comparison checks against `=== undefined`, where the field only declares `null` as an option, thus TS complains that the value might still be `null`. This change just spills a bunch of `any` over the code to get it to compile in both 3.6 and 3.7. The casts shoulb be removed once the code is migrated.
crisbeto
reviewed
Dec 9, 2019
mprobst
force-pushed
the
initialHeight
branch
from
22e0c74 to
57399ac
Compare
|
@crisbeto ack, I apparently pushed a fix to the wrong remote branch. Should be good now I hope. |
crisbeto
added
P3
|
Marking as merge safe because it only changes the type of a private property to |
|
FYI, in the future, the correct commit message would be Due to this commit message issue, the release notes include this change in |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript 3.7 flags the assignment on line 250 because
style.heightmust not benull.The underlying reason though appears to be that the comparison checks against
=== undefined, where the field only declaresnullas an option. The field is not initialized, soundefinedis the correct value to compare to and type to use.