fix(material/list): Do not rely on input binding order #17501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
requested review from
crisbeto,
devversion and
jelbourn
as code owners
googlebot
added
the
cla: yes
This change ensures that setting `value` does not clear the `selected` input until after the first change detection cycle. Ivy sets inputs based on the order they appear in the templates. Fixes angular#17500
crisbeto
reviewed
Oct 25, 2019
crisbeto
added
P2
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that setting
valuedoes not clear theselectedinput until after the first change detection cycle. Ivy sets inputs
based on the order they appear in the templates.
Fixes #17500