Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(slide-toggle): move harness out of experimental #17132

Merged
merged 1 commit into from
Sep 18, 2019
Merged

feat(slide-toggle): move harness out of experimental #17132

merged 1 commit into from
Sep 18, 2019

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround pr: merge safe target: major This PR is targeted for the next major release labels Sep 18, 2019
@mmalerba mmalerba added this to the 9.0.0 milestone Sep 18, 2019
@mmalerba mmalerba requested a review from jelbourn September 18, 2019 16:22
@mmalerba mmalerba requested review from crisbeto, devversion and a team as code owners September 18, 2019 16:22
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 18, 2019
devversion
devversion approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Sep 18, 2019
@mmalerba mmalerba merged commit 15ba871 into angular:master Sep 18, 2019
@mmalerba mmalerba deleted the mv-slide-toggle-harness branch September 18, 2019 17:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @devversion @jelbourn @googlebot