fix(a11y): remove aria-describedby attribute when no descriptions are left #17074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
aria-describer-empty
branch
from
a7532a9 to
8124fee
Compare
… left Currently the `AriaDescriber` will leave an empty `aria-describedby` attribute once all of the descriptions have been removed. These changes remove the attribute completely in order to avoid potential a11y issues. Fixes angular#17070.
crisbeto
force-pushed
the
aria-describer-empty
branch
from
8124fee to
045ea7a
Compare
jelbourn
added
merge: fix commit message
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Sep 24, 2019
… are left (angular#17074) Currently the `AriaDescriber` will leave an empty `aria-describedby` attribute once all of the descriptions have been removed. These changes remove the attribute completely in order to avoid potential a11y issues. Fixes angular#17070. (cherry picked from commit e66de46)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
AriaDescriberwill leave an emptyaria-describedbyattribute once all of the descriptions have been removed. These changes remove the attribute completely in order to avoid potential a11y issues.Fixes #17070.