Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(expansion): allow expansion toggle indicator positioning #16257

Merged
merged 1 commit into from
Jun 11, 2019
Merged

feat(expansion): allow expansion toggle indicator positioning #16257

merged 1 commit into from
Jun 11, 2019

Conversation

josephperrott
Copy link
Member

Fixes #6726

@josephperrott josephperrott added the target: minor This PR is targeted for the next minor release label Jun 10, 2019
@josephperrott josephperrott requested a review from crisbeto June 10, 2019 19:39
@josephperrott josephperrott requested a review from jelbourn as a code owner June 10, 2019 19:39
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 10, 2019
@josephperrott josephperrott added the P2 The issue is important to a large percentage of users, with a workaround label Jun 10, 2019
@josephperrott josephperrott changed the title feat(expansion): allow expansion toggle indivicator positioning feat(expansion): allow expansion toggle indicator positioning Jun 10, 2019
@josephperrott josephperrott force-pushed the expansion-toggle-position branch from 8f84f1e to d23da00 Compare June 10, 2019 20:21
jelbourn
jelbourn approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 10, 2019
@josephperrott josephperrott force-pushed the expansion-toggle-position branch from d23da00 to 85e0aad Compare June 10, 2019 20:37
@josephperrott josephperrott force-pushed the expansion-toggle-position branch from 85e0aad to e78ec7a Compare June 10, 2019 21:47
@mmalerba mmalerba merged commit c3eac17 into angular:master Jun 11, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@josephperrott @RudolfFrederiksen
feat(expansion): allow expansion toggle indicator positioning (angula…
e05a7d3 
…r#16257)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
@josephperrott josephperrott deleted the expansion-toggle-position branch March 20, 2020 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow md-expansion-panel toggle to be placed at the beginning
4 participants
@josephperrott @jelbourn @googlebot @mmalerba