Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(popover-edit): Helper to reduce form state boilerplate #15939

Merged
merged 1 commit into from
Jun 5, 2019
Merged

feat(popover-edit): Helper to reduce form state boilerplate #15939

merged 1 commit into from
Jun 5, 2019

Conversation

kseamon
Copy link
Collaborator

@kseamon kseamon commented May 2, 2019

Honestly not sure if this is worthwhile, but throwing it out there for comment.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 2, 2019
@kseamon kseamon changed the title Popover edit persist by feat(popover-edit): Helper to reduce form state boilerplate May 2, 2019
@kseamon kseamon force-pushed the popover-edit-persist-by branch from ad234ef to 04a640f Compare May 9, 2019 18:25
@kseamon kseamon marked this pull request as ready for review May 9, 2019 18:25
@kseamon kseamon force-pushed the popover-edit-persist-by branch from 04a640f to 15e0699 Compare June 3, 2019 18:48
@kseamon kseamon requested a review from andrewseguin as a code owner June 3, 2019 18:48
@kseamon kseamon force-pushed the popover-edit-persist-by branch from 15e0699 to c8fc922 Compare June 3, 2019 21:33
@kseamon
Copy link
Collaborator Author

kseamon commented Jun 4, 2019

The one should be ready now too.

jelbourn
jelbourn approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 5, 2019
@josephperrott josephperrott merged commit 57b9902 into angular:master Jun 5, 2019
josephperrott pushed a commit that referenced this pull request Jun 10, 2019
@kseamon @josephperrott
feat(popover-edit): Helper class to reduce form state preservation bo…
3bc6020 
…ilerplate (#15939)
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@kseamon @RudolfFrederiksen
feat(popover-edit): Helper class to reduce form state preservation bo…
cab24ff 
…ilerplate (angular#15939)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kseamon @jelbourn @googlebot @josephperrott