Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Firebase JS SDK 5.0 #1628

Merged
merged 2 commits into from
May 12, 2018
Merged

Support Firebase JS SDK 5.0 #1628

merged 2 commits into from
May 12, 2018
+95 −84

Conversation

jamesdaniels
Copy link
Member

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

@jamesdaniels jamesdaniels mentioned this pull request May 12, 2018
Closed
@jamesdaniels jamesdaniels requested a review from davideast May 12, 2018 01:40
davideast
davideast approved these changes May 12, 2018
View reviewed changes
Copy link
Member

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I had to manually merge yarn.lock conflicts, which is always tricky. If it passes feel free to merge. If not, just regenerate the file locally and submit.

@davideast davideast merged commit b99bfa3 into master May 12, 2018
@davideast davideast deleted the firebase5 branch May 12, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideast davideast davideast approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesdaniels @davideast @googlebot