Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NgZone): isStable #8108

Closed
wants to merge 1 commit into from
Closed

feat(NgZone): isStable #8108

wants to merge 1 commit into from

Conversation

PatrickJS
Copy link
Member

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature
  • What is the current behavior? (You can also link to an open issue here)
    you have to use _isStable
  • What is the new behavior (if this is a feature change)?
    you can use the getter isStable
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    nope
  • Other information:
    I use _isStable for both the server and requestIdleCallback polyfill

@mhevery
Copy link
Contributor

mhevery commented Apr 17, 2016

Looks like you forgot to run lint. Also could you add test.

@mhevery mhevery self-assigned this Apr 17, 2016
@PatrickJS
Copy link
Member Author

oops, ya totes

@mhevery mhevery closed this in 587c119 May 19, 2016
@PatrickJS PatrickJS deleted the patch-9 branch May 20, 2016 01:43
KiaraGrouwstra pushed a commit to KiaraGrouwstra/angular that referenced this pull request Jun 10, 2016
KiaraGrouwstra pushed a commit to KiaraGrouwstra/angular that referenced this pull request Jun 21, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants