fix(router): canLoad should cancel a navigation instead of failing it #11001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsavkin
added
the
action: review
|
this addresses part of the concern in #10585 |
| @@ -22,3 +22,12 @@ export const PRIMARY_OUTLET = 'primary'; | |||
| export type Params = { | |||
| [key: string]: any | |||
| }; | |||
|
|
|||
| export class ErrorCancelingNavigation extends Error { | |||
There was a problem hiding this comment.
NavigationCancelingError sounds like a better name
|
public api spec needs to be updated |
IgorMinar
added
pr_state: LGTM
action: cleanup
vsavkin
force-pushed
the
can_load_should_work_as_as_can_activate
branch
from
12c5c3e to
786487f
Compare
vsavkin
added
action: merge
|
I'm still receiving this error when returning false from canLoad. Is this related? Returning false in canLoad should not return an error. |
|
Can you please file a new issue with a reproduction? thanks
…On Fri, Dec 15, 2017 at 10:17 AM Jason Yeomans ***@***.***> wrote:
I'm still receiving this error when returning false from canLoad. Is this
related?
Uncaught (in promise) Error: NavigationCancelingError: Cannot load children because the guard of the route "path: ''" returned false
Returning false in canLoad should not return an error.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#11001 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANM6Ev0fgcQpUBXRzwDH6dx0cMf3Kgmks5tAreggaJpZM4JqtZZ>
.
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently canLoad returning false fails a navigation instead of canceling it. This is different from canActivate.
This PR changes it so canLoad behaves similar to canActivate.