Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Wrong email validation in 2.1.13 #6279

Closed
mbeckenbach opened this issue Feb 16, 2014 · 3 comments
Closed

Wrong email validation in 2.1.13 #6279

mbeckenbach opened this issue Feb 16, 2014 · 3 comments

Comments

@mbeckenbach
Copy link

#6091 Same issue. Just updated to 2.1.13

bla@bla is valid without a toplevel domain

@Narretz
Copy link
Contributor

Narretz commented Feb 16, 2014

As stated in the issue, that's not technically a bug. You could also implement your own validation directive with a different regex. Or you can decorate the directive. (e.g. http://angular-tips.com/blog/2013/09/experiment-decorating-directives/)

@caitp
Copy link
Contributor

caitp commented Feb 16, 2014

Yeah, this is not a bug, if you want to force people to use such emails, you can follow @Narretz' suggestion.

@jmcclell
Copy link

jmcclell commented Mar 2, 2014

Technically correct is the best kind of correct, but there is also practical application. "blah" may be a valid hostname in a technical sense, but it isn't a world-accessible host name and to my knowledge there are zero world-accessible host names sans TLD. In other words, no one is signing up for my public service with an email missing a TLD. So, I don't believe you should fix the default behavior (as browsers also take your approach) but perhaps an option could be added so that the entire world doesn't have to decorate the built-in directive? I have a feeling you're going to see bug reports for this pop up again and again because it is confusing for people.

Anyway, sorry to rehash an old bug, but I also find myself looking for the best option to augment the default behavior to be real-world usable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants