Skip to content
This repository has been archived by the owner on Dec 4, 2017. It is now read-only.

Remove Reflect Metadata polyfill for core-js #1748

Closed
coryrylan opened this issue Jun 25, 2016 · 6 comments
Closed

Remove Reflect Metadata polyfill for core-js #1748

coryrylan opened this issue Jun 25, 2016 · 6 comments

Comments

@coryrylan
Copy link
Contributor

It looks like es7 reflect metadata is now in core-js. The CLI & Material are removing the separate package in favor of using core-js. The live examples and demos will need to be updated as well.

angular/angular-cli#853
angular/components#505

@Foxandxss
Copy link
Member

Foxandxss commented Jun 25, 2016

We are aware of that, but we haven't made a decision yet.

I'll put it on my list of things to discuss.

/cc @filipesilva

@filipesilva
Copy link
Contributor

Let's talk about it early next week.

@kylecordes
Copy link

core-js appears to do the whole job, and work very well. The advantage of fewer dependencies seems transparently obvious. So I will be very interested to see (and I hope a rationale is published) if the decision is made to keep the extra reflect-metadata.

@schmuli
Copy link

schmuli commented Jan 25, 2017

@filipesilva
Copy link
Contributor

@schmuli core-js includes reflect-metadata, and more. Angular itself just requires that reflect-metadata is present.

@schmuli
Copy link

schmuli commented Jan 25, 2017

My confusion was because there is the reflect-metadata NPM package, so I thought it was referring to the package, not the feature.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants