Shadowless DOM #936
Shadowless DOM #936
Conversation
| @@ -320,7 +327,8 @@ class Component extends Directive { | |||
| selector, | |||
| visibility, | |||
| exportExpressions, | |||
| exportExpressionAttrs}) | |||
| exportExpressionAttrs, | |||
There was a problem hiding this comment.
Should you update _cloneWithNewMap below ?
There was a problem hiding this comment.
Good catch! I wrote a test for this in 0c797cc
There was a problem hiding this comment.
One minor thing is also to update class level docs "Angular components use shadow-DOM for rendering their templates"
|
@jbdeboer I like to have return types on all methods. It makes it easier to understand the code and can also help with auto-completion. What do you think ? |
| part of angular.core.dom_internal; | ||
|
|
||
| @proxy | ||
| class ShadowlessShadowRoot implements dom.ShadowRoot { |
There was a problem hiding this comment.
ShadowRoot extends DocumentFragment and doesn't add too much more- perhaps just use DocumentFragment instead?
Alternatively this may be a good case for a custom element.
There was a problem hiding this comment.
This is used in onShadowRoot, which needs to be renamed.
We'll rework this later.
No description provided.